Skip to content

[CSSG-13]: Added login and signup page#7

Open
ayselomer wants to merge 2 commits intomainfrom
login-signup-onboarding
Open

[CSSG-13]: Added login and signup page#7
ayselomer wants to merge 2 commits intomainfrom
login-signup-onboarding

Conversation

@ayselomer
Copy link
Collaborator

@ayselomer ayselomer commented Mar 6, 2026

Linear

Issue:

What changes

Why it's being done

Summary

How to verify

  • Lint, format, and tests pass locally (bun run lint:all, bun run format:check:all, bun run test:all)

Notes

@linear
Copy link

linear bot commented Mar 6, 2026

Copy link
Member

@pmoharana-cmd pmoharana-cmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure to run linting and formatting commands because those are failing currently

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the login page can we have placeholder functions that will do something when we click the login button and maybe also create a blank forgot password screen

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make functions for logging in with github and google as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make two separate components for the "signup" view vs the "onboarding" view? You can make a new components directory in the app frontend/app folder and import it from there. Then you can conditionally render the components based on the current state

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants